Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't panic on Eventually(nil), fixing #555 #567

Merged
merged 1 commit into from
Jul 28, 2022
Merged

don't panic on Eventually(nil), fixing #555 #567

merged 1 commit into from
Jul 28, 2022

Conversation

thediveo
Copy link
Collaborator

@thediveo thediveo commented Jul 26, 2022 •
edited
Loading

  • treat a nil actual value to Eventually as any other value that isn't a func.
  • adds unit tests.

@onsi
Copy link
Owner

onsi commented Jul 28, 2022

hey @thediveo - sorry I never managed to circle back on #555 - this seems like the correct fix to me and puts nil on par with other non-function values.

@onsi onsi merged commit 9d1186f into onsi:master Jul 28, 2022
@thediveo
Copy link
Collaborator Author

"circling back" evokes images of Anden condors...

@onsi
Copy link
Owner

onsi commented Jul 28, 2022

😂

@thediveo thediveo deleted the issue-555-eventual-nilism branch July 28, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thediveo @onsi